From 38b7d20f29fea0eb3eab9ac9ee80a6c732b5ebd3 Mon Sep 17 00:00:00 2001
From: Benjamin <bstadlbauer@posteo.de>
Date: Thu, 2 Mar 2023 19:05:34 +0100
Subject: [PATCH] fixup! Add forms for adding recipes and versions

simple alternative author input
---
 recipes/forms.py                   |  2 --
 recipes/templates/add-version.html | 20 --------------------
 recipes/views.py                   |  8 ++++----
 3 files changed, 4 insertions(+), 26 deletions(-)

diff --git a/recipes/forms.py b/recipes/forms.py
index 1b322ac..6af1420 100644
--- a/recipes/forms.py
+++ b/recipes/forms.py
@@ -4,8 +4,6 @@ from .models import Recipe, Version, Ingredient
 class VersionForm(ModelForm):
 	recipe_id: int
 
-	use_user_for_author = BooleanField(initial=True, label='I am the author', required=False)
-
 	class Meta:
 		model = Version
 		fields = ['label', 'slug', 'body', 'alternative_author']
diff --git a/recipes/templates/add-version.html b/recipes/templates/add-version.html
index b508688..e67d86b 100644
--- a/recipes/templates/add-version.html
+++ b/recipes/templates/add-version.html
@@ -15,26 +15,6 @@
 </form>
 
 <script>
-	let userIsAuthorCheckbox = document.querySelector("#id_version-use_user_for_author");
-	let authorNameValue = "";
-
-	function enableAuthorNameInput() {
-		let authorName = document.querySelector("#id_version-alternative_author")
-
-		if (userIsAuthorCheckbox.checked) {
-			authorName.setAttribute("disabled", "");
-			authorNameValue = authorName.value;
-			authorName.value = "";
-		} else {
-			authorName.removeAttribute("disabled");
-			authorName.value = authorNameValue;
-		}
-	}
-
-	enableAuthorNameInput();
-
-	userIsAuthorCheckbox.addEventListener('input', enableAuthorNameInput)
-
 	let firstIngredientDiv = document.querySelector("input[id^=id_ingredient][id$=text]").parentElement;
 	let addIngredientButton = document.querySelector("#add-ingredient");
 	let form = document.querySelector("#add-version-form");
diff --git a/recipes/views.py b/recipes/views.py
index 1f8dd90..83d4914 100644
--- a/recipes/views.py
+++ b/recipes/views.py
@@ -51,11 +51,11 @@ def add_version(request, slug_recipe):
 
 		if version_form.is_valid() and ingredients_formset.is_valid():
 			version = version_form.save(commit=False)
-			if version_form.cleaned_data['use_user_for_author']:
-				version.user = request.user
-				version.alternative_author = ''
-			elif 'alternative_author' in version_form.cleaned_data:
+			version.user = request.user
+
+			if 'alternative_author' in version_form.cleaned_data:
 				version.alternative_author = version_form.cleaned_data['alternative_author']
+
 			version.recipe = recipe
 			version.save()