remove explicit permission checks
This commit is contained in:
parent
ebd397f351
commit
3d2f97b50f
|
|
@ -2,10 +2,8 @@
|
||||||
{% block title %}{{ recipe.title }}{% endblock %}
|
{% block title %}{{ recipe.title }}{% endblock %}
|
||||||
{% block main %}
|
{% block main %}
|
||||||
<h1>{{ recipe.title }}</h1>
|
<h1>{{ recipe.title }}</h1>
|
||||||
{% if perms.recipes.add_recipe %}
|
|
||||||
<p><a href="{% url 'edit-recipe' recipe.slug %}">Edit recipe name</a></p>
|
<p><a href="{% url 'edit-recipe' recipe.slug %}">Edit recipe name</a></p>
|
||||||
<p><a href="{% url 'add-version' recipe.slug %}">Add version</a></p>
|
<p><a href="{% url 'add-version' recipe.slug %}">Add version</a></p>
|
||||||
{% endif %}
|
|
||||||
<ul>
|
<ul>
|
||||||
{% for v in versions %}
|
{% for v in versions %}
|
||||||
<li><a href="{{ v.get_absolute_url }}">{{ v.label }}</a></li>
|
<li><a href="{{ v.get_absolute_url }}">{{ v.label }}</a></li>
|
||||||
|
|
|
||||||
|
|
@ -2,14 +2,10 @@
|
||||||
{% block title %}Recipes{% endblock %}
|
{% block title %}Recipes{% endblock %}
|
||||||
{% block main %}
|
{% block main %}
|
||||||
<h1>Recipes</h1>
|
<h1>Recipes</h1>
|
||||||
{% if perms.recipes.add_recipe %}
|
|
||||||
<p><a href="{% url 'add-recipe' %}">Add recipe</a></p>
|
<p><a href="{% url 'add-recipe' %}">Add recipe</a></p>
|
||||||
{% endif %}
|
<ul>
|
||||||
{% if perms.recipes.view_recipe %}
|
{% for recipe in recipes %}
|
||||||
<ul>
|
<li><a href="{{ recipe.get_absolute_url }}">{{ recipe.title }}</a></li>
|
||||||
{% for recipe in recipes %}
|
{% endfor %}
|
||||||
<li><a href="{{ recipe.get_absolute_url }}">{{ recipe.title }}</a></li>
|
</ul>
|
||||||
{% endfor %}
|
|
||||||
</ul>
|
|
||||||
{% endif %}
|
|
||||||
{% endblock %}
|
{% endblock %}
|
||||||
|
|
|
||||||
|
|
@ -5,11 +5,9 @@
|
||||||
{% if has_multiple_versions %}
|
{% if has_multiple_versions %}
|
||||||
<p><a href="{{ recipe.get_absolute_url }}">Show all versions</a></p>
|
<p><a href="{{ recipe.get_absolute_url }}">Show all versions</a></p>
|
||||||
{% endif %}
|
{% endif %}
|
||||||
{% if perms.recipes.add_recipe %}
|
|
||||||
<p><a href="{% url 'edit-recipe' recipe.slug %}">Edit recipe name</a></p>
|
<p><a href="{% url 'edit-recipe' recipe.slug %}">Edit recipe name</a></p>
|
||||||
<p><a href="{% url 'add-version' recipe.slug %}">Add version</a></p>
|
<p><a href="{% url 'add-version' recipe.slug %}">Add version</a></p>
|
||||||
<p><a href="{% url 'edit-version' recipe.slug version.slug %}">Edit Version</a></p>
|
<p><a href="{% url 'edit-version' recipe.slug version.slug %}">Edit Version</a></p>
|
||||||
{% endif %}
|
|
||||||
<ul>
|
<ul>
|
||||||
{% for i in ingredients %}
|
{% for i in ingredients %}
|
||||||
<li>{{ i.text }}</li>
|
<li>{{ i.text }}</li>
|
||||||
|
|
|
||||||
|
|
@ -1,7 +1,7 @@
|
||||||
from django.shortcuts import render, get_object_or_404
|
from django.shortcuts import render, get_object_or_404
|
||||||
from .models import Recipe, Version, Ingredient
|
from .models import Recipe, Version, Ingredient
|
||||||
from .forms import RecipeForm, VersionForm, IngredientFormSet
|
from .forms import RecipeForm, VersionForm, IngredientFormSet
|
||||||
from django.contrib.auth.decorators import login_required, permission_required
|
from django.contrib.auth.decorators import login_required
|
||||||
from django.urls import reverse
|
from django.urls import reverse
|
||||||
from django.http.response import HttpResponseRedirect
|
from django.http.response import HttpResponseRedirect
|
||||||
from django.conf import settings
|
from django.conf import settings
|
||||||
|
|
@ -10,13 +10,11 @@ def get_name_of_user(user):
|
||||||
return user.first_name if user.first_name else user.username
|
return user.first_name if user.first_name else user.username
|
||||||
|
|
||||||
@login_required
|
@login_required
|
||||||
@permission_required('recipes.view_recipe')
|
|
||||||
def recipes(request):
|
def recipes(request):
|
||||||
recipes = Recipe.objects.all()
|
recipes = Recipe.objects.all()
|
||||||
return render(request, 'recipes.html', context={'recipes': recipes})
|
return render(request, 'recipes.html', context={'recipes': recipes})
|
||||||
|
|
||||||
@login_required
|
@login_required
|
||||||
@permission_required('recipes.view_recipe')
|
|
||||||
def version(request, slug_recipe, slug_version):
|
def version(request, slug_recipe, slug_version):
|
||||||
recipe = get_object_or_404(Recipe, slug=slug_recipe)
|
recipe = get_object_or_404(Recipe, slug=slug_recipe)
|
||||||
has_multiple_versions = recipe.versions.all().count() > 1 # type: ignore
|
has_multiple_versions = recipe.versions.all().count() > 1 # type: ignore
|
||||||
|
|
@ -26,7 +24,6 @@ def version(request, slug_recipe, slug_version):
|
||||||
return render(request, 'version.html', context={'recipe': recipe, 'has_multiple_versions': has_multiple_versions, 'version': version, 'ingredients': ingredients})
|
return render(request, 'version.html', context={'recipe': recipe, 'has_multiple_versions': has_multiple_versions, 'version': version, 'ingredients': ingredients})
|
||||||
|
|
||||||
@login_required
|
@login_required
|
||||||
@permission_required('recipes.view_recipe')
|
|
||||||
def recipe(request, slug):
|
def recipe(request, slug):
|
||||||
recipe = get_object_or_404(Recipe, slug=slug)
|
recipe = get_object_or_404(Recipe, slug=slug)
|
||||||
versions = recipe.versions.all() # type: ignore
|
versions = recipe.versions.all() # type: ignore
|
||||||
|
|
@ -86,7 +83,6 @@ def edit_recipe(request, slug):
|
||||||
return render(request, 'edit-recipe.html', {'form': form})
|
return render(request, 'edit-recipe.html', {'form': form})
|
||||||
|
|
||||||
@login_required
|
@login_required
|
||||||
@permission_required('recipes.add_recipe')
|
|
||||||
def add_version(request, slug):
|
def add_version(request, slug):
|
||||||
recipe = get_object_or_404(Recipe, slug=slug)
|
recipe = get_object_or_404(Recipe, slug=slug)
|
||||||
if (recipe.versions.all().count() > 0): # type: ignore
|
if (recipe.versions.all().count() > 0): # type: ignore
|
||||||
|
|
@ -118,7 +114,6 @@ def add_version(request, slug):
|
||||||
return render(request, 'add-version.html', {'version_form': version_form, 'ingredients_formset': ingredients_formset})
|
return render(request, 'add-version.html', {'version_form': version_form, 'ingredients_formset': ingredients_formset})
|
||||||
|
|
||||||
@login_required
|
@login_required
|
||||||
@permission_required('recipes.add_recipe')
|
|
||||||
def edit_version(request, slug_recipe, slug_version):
|
def edit_version(request, slug_recipe, slug_version):
|
||||||
recipe = get_object_or_404(Recipe, slug=slug_recipe)
|
recipe = get_object_or_404(Recipe, slug=slug_recipe)
|
||||||
version = get_object_or_404(Version, recipe=recipe, slug=slug_version)
|
version = get_object_or_404(Version, recipe=recipe, slug=slug_version)
|
||||||
|
|
|
||||||
|
|
@ -18,7 +18,7 @@
|
||||||
{% endif %}
|
{% endif %}
|
||||||
</ul>
|
</ul>
|
||||||
<ul>
|
<ul>
|
||||||
{% if perms.recipes %}<li><a href="{% url 'recipes' %}">Recipes</a></li>{% endif %}
|
<li><a href="{% url 'recipes' %}">Recipes</a></li>
|
||||||
</ul>
|
</ul>
|
||||||
</nav>
|
</nav>
|
||||||
<main>
|
<main>
|
||||||
|
|
|
||||||
|
|
@ -3,8 +3,6 @@
|
||||||
{% block main %}
|
{% block main %}
|
||||||
<h1>Barn</h1>
|
<h1>Barn</h1>
|
||||||
<ul>
|
<ul>
|
||||||
{% if perms.recipes %}
|
<li><h2><a href="{% url 'recipes' %}">Recipes</a></h2></li>
|
||||||
<li><h2><a href="{% url 'recipes' %}">Recipes</a></h2></li>
|
|
||||||
{% endif %}
|
|
||||||
</ul>
|
</ul>
|
||||||
{% endblock %}
|
{% endblock %}
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue