From a78be3378ba12ad1e779d2b895d3002907fa4d3e Mon Sep 17 00:00:00 2001 From: Benjamin Date: Mon, 6 Mar 2023 17:48:51 +0100 Subject: [PATCH] refactor --- recipes/views.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/recipes/views.py b/recipes/views.py index cde3273..898f670 100644 --- a/recipes/views.py +++ b/recipes/views.py @@ -69,7 +69,7 @@ def add_recipe(request): ingredients_formset = IngredientFormSet(queryset=Ingredient.objects.none(), prefix=INGREDIENTS_FORMSET_PREFIX) return render(request, 'add-recipe.html', {'recipe_form': recipe_form, 'version_form': version_form, 'ingredients_formset': ingredients_formset}) -# TODO refactor Recipe.objects.get ... with get_object_or_404 + @login_required def edit_recipe(request, slug): recipe = get_object_or_404(Recipe, slug=slug) @@ -88,7 +88,7 @@ def edit_recipe(request, slug): @login_required @permission_required('recipes.add_recipe') def add_version(request, slug): - recipe = Recipe.objects.get(slug=slug) + recipe = get_object_or_404(Recipe, slug=slug) if (recipe.versions.all().count() > 0): # type: ignore version_initial = {'label': '', 'slug': ''} else: